Fix: staking with incorrect refs – rework getRefferalAddress #600
+31
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves SI-1817
Fixes the issue, when it is not possible to stake if some incorrect ref is provided.
Testing notes
The logic of processing the provided ref address looks like this:
It is possible to pass ENS names as a ref. We assume that no one uses 'lido.fi' ENS name, because not all ENS names end with '.eth' and it is technically possible to have 'lido.fi' ENS name.
Checked with refs:
?ref=blog.lido.fi
– no ENS request, ignoring the ref/?ref=https://test
– no ENS request, ignoring the ref?ref=test.com
– we have to do a ENS request, because it is a possible ENS name. If the name is not resolved – ignore, return fallback.Checklist: